pnowak/Tic-Tac-Toe
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

develop #1

Merged
swarga merged 3 commits from develop into master 2020-12-23 23:44:42 +01:00
Conversation 0 Commits 3 Files Changed 1 +15 -9
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 71d34178f0 - Show all commits

24
main.py
View File

@ -17,6 +17,16 @@ class TicTacToe:
""" """
swarga commented 2020-12-23 22:36:07 +01:00
Outdated
Review
Copy Link

Takie rzeczy dobrze byłoby przenieść do konstruktora (pamiętaj o self!)

Takie rzeczy dobrze byłoby przenieść do konstruktora (pamiętaj o `self`!)
def run(self): def run(self):
player1 = Player("X")
player2 = Player("O")
board = Board()
swarga commented 2020-12-23 22:37:15 +01:00
Outdated
Review
Copy Link

Ten warunek jest już niepotrzebny, skoro masz isWin().
Gra powinna trwać do wygranej lub remisu.

Ten warunek jest już niepotrzebny, skoro masz `isWin()`. Gra powinna trwać do wygranej lub remisu.
for x in range(1,10):
board.make_move(player1.token, player1.make_random_move(board.state))
board.print()
board.make_move(player2.token, player2.make_random_move(board.state))
board.print()
class Board: class Board:
def __init__(self): def __init__(self):
@ -42,24 +52,20 @@ class Board:
class Player: class Player:
def __init__(self, token): def __init__(self, token):
self.token = token self.token = token
def make_random_move(self, state): def make_random_move(self, state):
emptyField = True emptyField = True
while emptyField: while emptyField:
field = state[randint(0,8)] randomField = randint(0,8)
field = state[randomField]
if field == " ": if field == " ":
swarga commented 2020-12-23 22:39:13 +01:00
Review
Copy Link

Do zaktualizowania.

Do zaktualizowania.
return return randomField
player1 = Player("X")
player2 = Player("O")
game = TicTacToe() game = TicTacToe()
game.run() game.run()
for x in range(1,10):
player.make_random_move(game.state)
game.print()
player1.make_random_move(game.state)
game.print()